Fix file extension detection for files with multiple dot separators#1408
Merged
fviard merged 3 commits intos3tools:masterfrom Jan 18, 2025
Merged
Conversation
Contributor
|
Thank you for your PR, indeed the existing code looks very strange, and my best guess is that it was not done on purpose but a confusion with the count argument of the python split. |
fviard
reviewed
Jan 13, 2025
Contributor
|
And btw, don't worry about the automatic test failing, it is not related to your PR :-) |
Contributor
|
@nerlihmax, @fviard LGTM. |
Contributor
|
Merged, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I have issues with the flag
--add-encoding-exts=js,html,csswhen uploads js static on production buckets. My files have names likewidget-no-csr.oWiXNN3Poy.jsorwidget-no-csr.oWiXNN3Poy.js.gz, where is more than one dot symbol separator. Becauses3cmd/S3/S3.py
Line 736 in 10aea09
oWiXNN3Poyfor first file andjsfor second. That looks like a bug. I fixed that, but I think it could be kind of dangerous because it breaks backward compability.